Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle timezone and recurring events #95

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

eigenmannmartin
Copy link
Member

@eigenmannmartin eigenmannmartin commented Nov 11, 2021

reimplementation of #90
closes #89

kudos to @RickMeasham and @tresni

I have manually counted all entries in outlook for the test_cest case. :-)

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #95 (b7062ab) into master (c368ad8) will increase coverage by 2.18%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   87.84%   90.02%   +2.18%     
==========================================
  Files           4        4              
  Lines         362      381      +19     
  Branches       93       97       +4     
==========================================
+ Hits          318      343      +25     
+ Misses         21       17       -4     
+ Partials       23       21       -2     
Impacted Files Coverage Δ
icalevents/icalparser.py 91.00% <93.33%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c368ad8...b7062ab. Read the comment docs.

@patrick-sb
Copy link

Hi @eigenmannmartin - we ran into the same errors that your PR fixes (thanks!), and noticed that it wasn't being merged. We've decided to fork the repo at https://github.com/teamsurfboard/icalevents because we're depending on it in prod - if you'd like to copy your PR over then we'd be happy to merge it.

@elizaaverywilson elizaaverywilson merged commit 01ee1e3 into master Sep 16, 2022
@elizaaverywilson elizaaverywilson deleted the recurring-events-and-timezones branch September 19, 2022 22:14
capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
…ezones

handle timezone and recurring events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurring events off by 24 hours when time zone offset is less than start time of event
3 participants