Fix click v7 version_option compatibility (#1410)

It looks like the ternary was committed backwards in #1400, since the `package_name` option was add in click 8, but is only being passed in click 7. That caused `pip-tools` to error on import when installed alongside click 7.
jazzband · Jun 9, 2021 · 32a8834 · 32a8834
1 parent 6ed9301
commit 32a8834
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/piptools/scripts/compile.py b/piptools/scripts/compile.py
@@ -34,7 +34,7 @@
 METADATA_FILENAMES = frozenset({"setup.py", "setup.cfg", "pyproject.toml"})
 
 # TODO: drop click 7 and remove this block, pass directly to version_option
-version_option_kwargs = {} if IS_CLICK_VER_8_PLUS else {"package_name": "pip-tools"}
+version_option_kwargs = {"package_name": "pip-tools"} if IS_CLICK_VER_8_PLUS else {}
 
 
 def _get_default_option(option_name: str) -> Any:

diff --git a/piptools/scripts/sync.py b/piptools/scripts/sync.py
@@ -20,7 +20,7 @@
 DEFAULT_REQUIREMENTS_FILE = "requirements.txt"
 
 # TODO: drop click 7 and remove this block, pass directly to version_option
-version_option_kwargs = {} if IS_CLICK_VER_8_PLUS else {"package_name": "pip-tools"}
+version_option_kwargs = {"package_name": "pip-tools"} if IS_CLICK_VER_8_PLUS else {}
 
 
 @click.command(context_settings={"help_option_names": ("-h", "--help")})