Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include the implementation in the depcache #1050

Merged
merged 1 commit into from
Jan 31, 2020
Merged

include the implementation in the depcache #1050

merged 1 commit into from
Jan 31, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jan 30, 2020

Resolves #1049

Changelog-friendly one-liner: Ensure that depcache considers the python implementation such that (for example) cpython3.6 does not poison the results of pypy3.6.

Contributor checklist
  • Provided the tests for the changes. (I did not, this doesn't really fit well into the current testsuite)
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1050 into master will increase coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1050      +/-   ##
==========================================
+ Coverage   98.60%   99.50%   +0.90%     
==========================================
  Files          34       34              
  Lines        2441     2446       +5     
  Branches      307      306       -1     
==========================================
+ Hits         2407     2434      +27     
+ Misses         25        6      -19     
+ Partials        9        6       -3     
Impacted Files Coverage Δ
piptools/repositories/pypi.py 95.60% <0.00%> (+2.43%) ⬆️
tests/test_repository_pypi.py 100.00% <0.00%> (+22.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a052b...8829ff7. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev added this to the 4.4.1 milestone Jan 31, 2020
@atugushev atugushev merged commit 80a0772 into jazzband:master Jan 31, 2020
@atugushev
Copy link
Member

@asottile thanks!

@asottile asottile deleted the implementation_specific_cache branch January 31, 2020 03:19
@asottile
Copy link
Contributor Author

no problem! thanks for the quick review! this affected us at Lyft :)

@atugushev
Copy link
Member

pip-tools v4.4.1 is released.

@asottile happy to know you use pip-tools 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache Related to dependency cache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

piptools depcache is shared between implementations causing incorrect dependencies
2 participants