Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to for-else block #1117

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Refactor to for-else block #1117

merged 1 commit into from
Apr 25, 2020

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Apr 25, 2020 •
edited
Loading

I've reconsidered my opinion about for-else statement.

Addresses #949 (comment)

@atugushev atugushev added the refactor Refactoring code label Apr 25, 2020
@atugushev atugushev marked this pull request as ready for review April 25, 2020 03:07
@atugushev atugushev mentioned this pull request Apr 25, 2020
Merged
3 tasks
@codecov
Copy link

codecov bot commented Apr 25, 2020 •
edited
Loading

Codecov Report

Merging #1117 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1117   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          36       36           
  Lines        2645     2646    +1     
  Branches      320      320           
=======================================
+ Hits         2631     2632    +1     
  Misses          8        8           
  Partials        6        6
Impacted Files Coverage Δ
piptools/repositories/pypi.py 94.82% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d84a4c...606c65c. Read the comment docs.

AndydeCleyre
AndydeCleyre approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@AndydeCleyre AndydeCleyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I do prefer this way in this case. Thanks!

@atugushev atugushev merged commit 9865035 into jazzband:master Apr 25, 2020
@atugushev atugushev deleted the refactor-to-for-else branch April 25, 2020 03:28
@atugushev
Copy link
Member Author

@AndydeCleyre thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndydeCleyre AndydeCleyre AndydeCleyre approved these changes

Assignees
No one assigned
Labels
refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atugushev @AndydeCleyre