Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore eggs hashes from PyPI JSON API #1122

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Ignore eggs hashes from PyPI JSON API #1122

merged 1 commit into from
Apr 30, 2020

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Apr 27, 2020 •
edited
Loading

Fixes #1121.

Changelog-friendly one-liner: Ignore hashes for *.egg files in pip-compile.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 5.1.1 milestone Apr 27, 2020
@atugushev atugushev mentioned this pull request Apr 27, 2020
Closed
@graingert
Copy link
Member

can we get the set of hashable types from pip?

@atugushev
Copy link
Member Author

@graingert

can we get the set of hashable types from pip?

AFAIK we can't get that info.

@codecov
Copy link

codecov bot commented Apr 27, 2020 •
edited
Loading

Codecov Report

Merging #1122 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          36       36           
  Lines        2646     2647    +1     
  Branches      320      320           
=======================================
+ Hits         2632     2633    +1     
  Misses          8        8           
  Partials        6        6
Impacted Files Coverage Δ
tests/test_repository_pypi.py 100.00% <ø> (ø)
piptools/repositories/pypi.py 94.84% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40414a...69b5956. Read the comment docs.

AndydeCleyre
AndydeCleyre approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@AndydeCleyre AndydeCleyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, and good test case work!

@auvipy auvipy merged commit 0c3d022 into jazzband:master Apr 30, 2020
@atugushev atugushev deleted the ignore-eggs-hashes-1121 branch April 30, 2020 16:54
@atugushev
Copy link
Member Author

@AndydeCleyre @auvipy thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@AndydeCleyre AndydeCleyre AndydeCleyre approved these changes

@graingert graingert graingert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.

pip-compile --generate-hashes including bdist_egg hashes
4 participants
@atugushev @graingert @AndydeCleyre @auvipy