-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grouping of requirements to handle editables better #1132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 36 37 +1
Lines 2642 2678 +36
Branches 318 322 +4
=======================================
+ Hits 2628 2664 +36
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you!
This last commit introduced a regression when using the same zip file with different subdirectories (#1155). |
Fixes #1115 , or at least the test cases added there and in vphilippon#1
Changelog-friendly one-liner: Fix grouping of editables and non-editables
Contributor checklist