Fix py27 failing jobs

[atugushev]

Refs pypa/setuptools-scm#442

1. Upgrade virtualenv fixed issue with path.py

File "/tmp/easy_install-KNyzCx/jaraco.windows-5.0.0/temp/easy_install-m7aKTl/path.py-12.4.0/temp/easy_install-LMhEDY/more-itertools-8.3.0/more_itertools/more.py", line 482
    yield from iterable
             ^
SyntaxError: invalid syntax

2. Released setuptools-scm-4.1.0 fixed issue with:

File "c:\users\vssadm~1\appdata\local\temp\pip-install-yxxmaf\setuptools-scm\src\setuptools_scm\git.py", line 9, in <module>
    from os.path import samefile
ImportError: cannot import name samefile

[codecov]

Codecov Report

Merging #1151 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1151   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          36       36           
  Lines        2752     2752           
  Branches      326      326           
=======================================
  Hits         2738     2738           
  Misses          8        8           
  Partials        6        6           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09f9ee...baa10c5. Read the comment docs.

[atugushev]

Oof, keep py27 alive till Jan 2021 would be tough... 😞

[AndydeCleyre]

I'm all for upgrading past these problems. Only 1 and a half questions:

• is this this adding virtualenv to py3 workflows when it wasn't there before?
  • if so, is that necessary?

[atugushev]

@AndydeCleyre

It's not necessary for py3, but as we've seen before (#984) it's better to install a fresh virtualenv. Just in case.

[AndydeCleyre]

If virtualenv is not used at all by our py3 workflow, I don't think we should install it in our py3 workflow.

[atugushev]

@AndydeCleyre

tox uses virtualenv as a dependency.

[AndydeCleyre]

Alright, if the py3 flow does need virtualenv installed, then yes, let's keep it fresh.

[atugushev]

@AndydeCleyre

Thank you so much! 🙏