-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -h alias for --help option #1163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1163 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 36 36
Lines 2839 2839
Branches 333 333
=======================================
Hits 2825 2825
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jan25,
Thanks for your contribution! Looks good. I'd prefer to pass the dict
directly to the command()
. See the suggestions below. Let me know what you think.
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
Co-authored-by: Albert Tugushev <albert@tugushev.ru>
@atugushev thanks for the review. I like your idea of passing dict value as named arg, so accepted suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Nice first contribution! 🎉 Thanks! |
Add shortcut option for help to support
pip-compile|sync -h
Changelog-friendly one-liner: Add -h alias for --help option
Contributor checklist