Remove support for EOL Python 3.5 and 2.7 #1243
Conversation
|
I marked this for the 6.0.0 milestone, but I'm not sure if that is considered correct. This change was suggested in #1222. I'll also copy over my questions from that PR, so the thread can continue here: What is the pip-tools policy on supported Pythons? If we're using EOL as a guideline, then we should begin work towards dropping Python 2. Something I'm happy to contribute to. See https://devguide.python.org/#status-of-python-branches Or, on the other hand, are we trying to match the pip support? If so, they still support Python 3.5. Or, is the policy to drop EOL Pythons except 2.7? I looked through the docs and wasn't able to find anything explicit. I could add something to https://github.com/jazzband/pip-tools#versions-and-compatibility once I understand the policy. My preference is to follow Python EOL schedule, but I recognize that may be too fast for some projects that use pip-tools. |
That's correct. See 4.0.0 release for example.
Usually
Cool! That would be awesome! |
Typo: it's actually |
|
@atugushev If we're going make a new major release with backward incompatible changes, WDYT about taking this opportunity to drop Python 2? Python 2 has now been EOL for nearly a year. Python 2 users could continue using old version of pip-tools until they're ready to upgrade their project. We could even cut one more minor release so Python 2 users have one more chance to receive updated features (such as the new pip compatibility). Removing it would reduce compatibility code, CI resources, and other maintenance concerns. As well, we could begin to take advantage of newer Python features and patterns. pytest, click, and other transient dependencies have removed or are removing Python 2 support. Here are the PyPI statistics for the last three months. It shows Python 2 downloads before 20% and this percentage has been falling.
I'm am willing to do the necessary work. Cheers. |
Since |
|
Great to hear! The latest revision of this PR drops Python 2.7 as well. |
|
def test_diff_should_install_with_markers(from_line):
installed = []
reqs = [from_line("subprocess32==3.2.7 ; python_version=='2.7'")]
to_install, to_uninstall = diff(reqs, installed)
assert {str(x.req) for x in to_install} == (
{"subprocess32==3.2.7"} if sys.version.startswith("2.7") else set()
)
assert to_uninstall == set()
def test_diff_should_uninstall_with_markers(fake_dist, from_line):
installed = [fake_dist("subprocess32==3.2.7")]
reqs = [from_line("subprocess32==3.2.7 ; python_version=='2.7'")]
to_install, to_uninstall = diff(reqs, installed)
assert to_install == set()
assert to_uninstall == (
set() if sys.version.startswith("2.7") else {"subprocess32"}
)Also pyupgrade is intentionally timid in upgrading to f-strings, https://github.com/ikamensh/flynt (optionally with |
|
Thanks for the review @hugovk I applied your suggestions in the latest revision. |
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 37 36 -1
Lines 2980 2919 -61
Branches 331 325 -6
==========================================
- Hits 2970 2909 -61
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
jdufresne
changed the title
https://github.com/asottile/pyupgrade Cleanups: - set comprehension - drop default open() argument
Python 3.5 went EOL 2020-09-30. For a list of supported Python versions, see: https://devguide.python.org/#status-of-python-branches For a list of EOL Python versions and their dates, see: https://devguide.python.org/devcycle/#end-of-life-branches
Python 2.7 went EOL 2020-01-01. For a list of supported Python versions, see: https://devguide.python.org/#status-of-python-branches For a list of EOL Python versions and their dates, see: https://devguide.python.org/devcycle/#end-of-life-branches Removing support reduces compatibility code, CI resources, and other maintenance concerns. As well, can begin to take advantage of newer Python features and patterns. Cleanups: - Use f-strings - Drop __future__ imports - Drop file encoding cookies "# coding: utf-8" - Drop uses of six - Use stdlib TemporaryDirectory and unittest.mock - Use newer metaclass syntax - Drop now unnecessary fs_str() function - Drop inheritance from "object", all Python 3 classes are new-style classes - Remove unnecessary coerce to string/bytes calls - Use updated subprocess APIs
- Monkey patch sys.stdin using io.StringIO(). This avoids the need to use yet-another-tool rather than the tools providing by the test library. - This reduces indentation to slightly improve readability. - Allows for more accurate assertion of stdout and stderr.
capfd was used to workaround a compatibility issue between Python 2, Windows and Click. With Python 2 gone, can use capsys.
Introduced in Python 3.5
https://build.opensuse.org/request/show/962444 by user mcepl + dimstar_suse - version update to 6.5.1 Backwards Incompatible Changes: - Remove support for EOL Python 3.5 and 2.7 ([#1243](jazzband/pip-tools#1243)). Thanks @jdufresne - Remove deprecated `--index/--no-index` option from `pip-compile` ([#1234](jazzband/pip-tools#1234)). Thanks @jdufresne See CHANGELOG.md for more
Python 3.5 went EOL 2020-09-30.
For a list of supported Python versions, see:
https://devguide.python.org/#status-of-python-branches
For a list of EOL Python versions and their dates, see:
https://devguide.python.org/devcycle/#end-of-life-branches
Contributor checklist