Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider specifiers for equality operator to pin a dependency in make_install_requirement #1323

Merged
merged 11 commits into from
Feb 25, 2021
Merged

Consider specifiers for equality operator to pin a dependency in make_install_requirement #1323

merged 11 commits into from
Feb 25, 2021

Commits on Feb 24, 2021

  1. Consider specifiers for equality operator to pin a dependency in 

    make_install_requirement

- Changed function signature to take ireq directly rather than passing its
members one by one
- Changed type hint for version as I was getting a pip Version rather than
a string, maybe there are some parts of the code calling with string though
- Can confirm it generates a pinned torch with === in my use case as
expected
    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7ebcb50 View commit details
    Browse the repository at this point in the history

  2. Apply tox -e checkqa

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    37c84a7 View commit details
    Browse the repository at this point in the history

  3. Prefer forcing version to string rather than building a Version objec… 

    …t from

a specifier version as it made tests fail
    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    6a3b232 View commit details
    Browse the repository at this point in the history

  4. Rename variables to have clearer names

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    12dace5 View commit details
    Browse the repository at this point in the history

  5. Write test for requirements pinned with === and multiple pin sources 

    - Use case example where torch has multiple pin sources
    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    eface67 View commit details
    Browse the repository at this point in the history

  6. Use fake test packages which demonstrates the torch use-case

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    37029fd View commit details
    Browse the repository at this point in the history

  7. Network is not required by the test anymore, remove it

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    2711940 View commit details
    Browse the repository at this point in the history

  8. Pin test_package_2 with == operator

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    04154d2 View commit details
    Browse the repository at this point in the history

  9. Add test cases to check different combinations of pins

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f77201c View commit details
    Browse the repository at this point in the history

  10. Parametrize test, use simple versions

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    dfb28ac View commit details
    Browse the repository at this point in the history

  11. Add test ids

    @IceTDrinker
    IceTDrinker committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    8338272 View commit details
    Browse the repository at this point in the history