Write out default index when it is provided as--extra-index-url
#1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the default index is provided as `--extra-index-url` it can not safely be dropped from the written output since this changes behaviour when the output is synced. While jazzband#756 Explicitly introduced tests for the opposite this seams to have been a mistake since otherwise the following lines comment about making an exception would be nonsensical.
fahrradflucht
changed the title
--extra-index-url
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
- Coverage 99.62% 99.62% -0.01%
==========================================
Files 33 33
Lines 2921 2920 -1
Branches 318 318
==========================================
- Hits 2910 2909 -1
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
|
@atugushev Since you wrote that test, did I interpret that right? |
atugushev
reviewed
Feb 19, 2021
|
@fahrradflucht thanks for the contribution! 🎉 |
|
pip-tools |
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default index is provided as
--extra-index-urlit can not safely be dropped from the written output since this changes behavior when the output is synced.While #756 Explicitly introduced tests for the opposite, this seams to have been a mistake since otherwise the following lines comment about making an exception would be nonsensical.
Changelog-friendly one-liner: Write out default index when it is provided as
--extra-index-url.Contributor checklist