Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to set compile cache with env var PIP_TOOLS_CACHE_DIR #1368

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

AndydeCleyre
Copy link
Contributor

@AndydeCleyre AndydeCleyre commented Mar 25, 2021

Fixes bug introduced in #1238 and exposed by #1357

#1238's intent was to remove unnecessary environment variable handling that pip was taking care of. This pip-tools environment variable was an accidental casualty. This became apparent when parallel tests proved unstable, due to a shared cache path, while we already have an autouse fixture to isolate them (using PIP_TOOLS_CACHE_DIR env var).

Changelog-friendly one-liner: Restore ability to set compile cache with env var PIP_TOOLS_CACHE_DIR

Contributor checklist
  • Provided the tests for the changes. -- I expect existing tests become stable again
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #1368 (0b6efed) into master (1a399a6) will not change coverage.
The diff coverage is n/a.

❗ Current head 0b6efed differs from pull request most recent head 6986bd3. Consider uploading reports for the commit 6986bd3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1368   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          33       33           
  Lines        2940     2940           
  Branches      308      308           
=======================================
  Hits         2930     2930           
  Misses          5        5           
  Partials        5        5           
Impacted Files Coverage Δ
piptools/scripts/compile.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a399a6...6986bd3. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Looks like it was removed accidentally.

@atugushev atugushev added this to the 6.1.0 milestone Mar 25, 2021
@atugushev atugushev merged commit 2dd787a into jazzband:master Mar 25, 2021
@RuRo
Copy link

RuRo commented Apr 1, 2021

@atugushev Sorry to bother you. I see, that you added this to the version 6.1.0 milestone. Do you have any rough ETA on when will 6.1.0 get released? If you don't have an ETA, or if it's not very soon, do you think you could quickly backport this and release it as a 6.0.2 update or something? Thanks!

@atugushev
Copy link
Member

Hello @RuRo! Thanks for pinging.

Do you have any rough ETA on when will 6.1.0 get released?

We are waiting for #1363 to be merged. It's in the review process for now. Unfortunately no ETA.

If you don't have an ETA, or if it's not very soon, do you think you could quickly backport this and release it as a 6.0.2 update or something?

It would take some effort, we haven't done backports before. I'd prefer to wait for 6.1.0 instead.

@webknjaz
Copy link
Member

webknjaz commented Apr 1, 2021

I have a GitHub App for easier backports (when they apply cleanly) but this would probably require supporting multiple release streams and an extra RM to handle release tasks.

@RuRo
Copy link

RuRo commented Apr 1, 2021

No problems, if you don't have a simple way to do a backport, then I'll just wait for 1363/6.1.0. Thanks.

atugushev added a commit to atugushev/pip-tools that referenced this pull request Apr 14, 2021
@atugushev
Copy link
Member

pip-tools v6.1.0 is released 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants