Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert 5.1.2 change that broke extras (seeks to address #1451) #1452

Closed
wants to merge 1 commit into from
Closed

Partially revert 5.1.2 change that broke extras (seeks to address #1451) #1452

wants to merge 1 commit into from

Conversation

gizmo385
Copy link

@gizmo385 gizmo385 commented Jul 14, 2021 •
edited by atugushev
Loading

This is a change that partially reverts c0b33e7, which was released as a part of version 5.1.2 and introduced the issue described in #1451.

I've (currently) refrained from copying over the details of that issue here, but if you'd prefer that I copy that additional info over into this PR, please let me know 😊

Regarding checklist below:

  • Unsure if additional tests are necessary to revert this behavior.
  • It looks like I lack the permissions necessary to add a label or adjust milestones within this PR.
Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Fixes #1451.

@gizmo385 gizmo385 mentioned this pull request Jul 14, 2021
Closed
@atugushev atugushev added bug fix resolver Related to dependency resolver labels Jul 17, 2021
@gizmo385
Partially revert 5.1.2 change that broke extras
55ef6e6 
Commit c0b33e7 on the pip-tools
upstream results in an issue that has been documented as #1451 on the
pip-tools repo.

#1451
@richafrank richafrank mentioned this pull request Sep 20, 2021
Merged
4 tasks
@AndydeCleyre
Copy link
Contributor

Thank you @gizmo385!

I'm going to close this PR in favor of #1486

@gizmo385
Copy link
Author

Sounds good! Thanks @AndydeCleyre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
resolver Related to dependency resolver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pip-compile is non-deterministic with multiple declarations of a dependency specifying extras
3 participants
@gizmo385 @AndydeCleyre @atugushev