-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable single-line annotations with pip-compile --annotation-style=line
#1477
Conversation
189234d
to
138dcbb
Compare
pip-compile --annotation-style=line
pip-compile --annotation-style=line
138dcbb
to
84912b5
Compare
pip-compile --annotation-style=line
pip-compile --annotation-style=line
Small detail: the term "split". Would "verbose" or "multiline" be friendlier? The verbose, multiline output is the default, so it seems a bit weird to use the term "split" as it is only "split" as opposed to the non-default "line" version. Would a |
Thanks for the feedback!
Multiline seems fine, but I don't prefer verbose, as we could have a more verbose single line annotation, theoretically. And it's not really more verbose anyway (no extra words). Whatever maintainers and community want to call it.
Well not that exactly, because that doesn't indicate that this only affects the annotation (hashes still get their own lines). But the question of a single flag vs a parameter style argument is a good one. I don't personally care about these details, and am going to mark this as ready for review to hopefully gather answers to these and other questions from other maintainers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Nice! I was thinking about the same approach as #1297 was really a not good feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments.
In general looks like it's doing what it says on the tin :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3b6cee0
to
ac65d5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻 Thanks for the work!
I see the continuation backslash on the last generated --hash
option is back again (gone in 5.5.0, see #1237). I presume there'll be some noise in users' VCS. Are we sure this is okay?
Thanks @atugushev!
|
Thanks for linking this issue. I forgot that we intentionally removed this when I made a comment above 🤦. Yeah, lets not include the final trailing slash. (Sorry for the back and forth on this.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest lgtm.
ac65d5e
to
8e48ab7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
All set, unless @atugushev or @jdufresne object to the latest commit. |
- Replace the map-based dispatching with more readable blocks - Catch (unlikely) invalid style value now that it won't raise a KeyError, although it should be caught earlier via Click args - Add a little more comment context to the use of 24 as column size Co-authored-by: Albert Tugushev <albert@tugushev.ru>
795445c
to
b6162c6
Compare
Thanks, @AndydeCleyre! 🎉 |
Released in |
pip-compile
gains--annotation-style=line
which uses the recently discontinued single-line annotation format.The current default behavior is unchanged, but can be explicitly passed as
--annotation-style=split
.This aims to fix #1306. Please provide feedback!
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.