-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.10 #1497
Merged
joshuadavidthomas
merged 3 commits into
jazzband:master
from
joshuadavidthomas:python3.10
Oct 9, 2021
Merged
Add support for Python 3.10 #1497
joshuadavidthomas
merged 3 commits into
jazzband:master
from
joshuadavidthomas:python3.10
Oct 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the traceback from before I commented out 3.11-dev: Traceback (most recent call last):
File "/home/runner/venv-3.11/lib/python3.11/site-packages/py/_vendored_packages/apipkg/__init__.py", line 145, in __makeattr
modpath, attrname = self.__map__[name]
~~~~~~~~~~~~^^^^^^
KeyError: '__spec__'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/runner/venv-3.11/bin/tox", line 5, in <module>
from tox import cmdline
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/tox/__init__.py", line 32, in <module>
from .session import cmdline # isort:skip
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/tox/session/__init__.py", line 20, in <module>
from tox import reporter
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/tox/reporter.py", line 127, in <module>
_INSTANCE = Reporter()
^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/tox/reporter.py", line 32, in __init__
self._reset(**kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/tox/reporter.py", line 38, in _reset
self.tw = py.io.TerminalWriter()
^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/py/_vendored_packages/apipkg/__init__.py", line 152, in __makeattr
result = importobj(modpath, attrname)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/runner/venv-3.11/lib/python3.11/site-packages/py/_vendored_packages/apipkg/__init__.py", line 72, in importobj
module = __import__(modpath, None, None, ['__doc__'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "<frozen importlib._bootstrap>", line 1083, in _find_and_load
File "<frozen importlib._bootstrap>", line 1043, in _find_and_load_unlocked
File "/home/runner/venv-3.11/lib/python3.11/site-packages/py/_vendored_packages/apipkg/__init__.py", line 150, in __makeattr
raise AttributeError(name)
^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: __spec__
Error: Process completed with exit code 1. I figured it would be outside the scope of this PR to fix this error, hence including the future version commented out. |
atugushev
reviewed
Oct 8, 2021
atugushev
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks @joshuadavidthomas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing tests
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.