Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyproject.toml file #1643

Merged
merged 9 commits into from
Nov 17, 2022
Merged

Add pyproject.toml file #1643

merged 9 commits into from
Nov 17, 2022

Conversation

otherJL0
Copy link
Contributor

@otherJL0 otherJL0 commented Jun 24, 2022 •
edited by atugushev
Loading

Resolves #1642.

  • Adding pyproject.toml file
  • Add comments for updated build process

Addresses #1642
Adding a sparse pyproject.toml file as replacement for setup.py
Adding comments to .github/workflows/release.yml for proposed build steps if setup.py is used

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

webknjaz
webknjaz reviewed Jun 25, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@otherJL0 otherJL0 requested a review from webknjaz June 28, 2022 18:09
@ssbarnea ssbarnea added the bug Something is not working label Nov 17, 2022
@ssbarnea ssbarnea added this to the 6.11.0 milestone Nov 17, 2022
atugushev
atugushev approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe strip obvious comments?

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@ssbarnea ssbarnea enabled auto-merge (squash) November 17, 2022 18:59
@ssbarnea ssbarnea merged commit 6870602 into jazzband:master Nov 17, 2022
@atugushev atugushev changed the title Adding pyproject.toml file Add pyproject.toml file Nov 18, 2022
@atugushev atugushev added enhancement Improvements to functionality and removed bug Something is not working labels Nov 18, 2022
webknjaz
webknjaz reviewed Nov 18, 2022
View reviewed changes
.github/workflows/release.yml

- name: Build package
run: |
python setup.py --version
python setup.py sdist --format=gztar bdist_wheel
python -m build
twine check dist/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--strict wouldn't hurt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact adding strict would require fixing another bug, that is why I did not mention it during review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@ssbarnea ssbarnea ssbarnea approved these changes

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
enhancement Improvements to functionality
Projects
None yet
Milestone
6.11.0
Development

Successfully merging this pull request may close these issues.

Build pip-tools using PyPA's build frontend tool
4 participants
@otherJL0 @ssbarnea @webknjaz @atugushev