Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types using fresh dependencies #1927

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jul 20, 2023

Since 21.1 pip has py.typed file, hence many updates on type annotations.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev
Copy link
Member Author

atugushev commented Jul 20, 2023

@AndydeCleyre

FYI, this is pre-step towards addressing the following comments:

@atugushev atugushev added the skip-changelog Avoid listing in changelog label Jul 20, 2023
@atugushev atugushev marked this pull request as ready for review July 20, 2023 19:23
@atugushev atugushev requested a review from AndydeCleyre July 20, 2023 20:16
@webknjaz
Copy link
Member

FWIW it might be useful to run mypy against several pip and Python versions (like min + max). Just the last one isn't going to cover a lot of stuff..

@atugushev
Copy link
Member Author

FWIW it might be useful to run mypy against several pip and Python versions (like min + max). Just the last one isn't going to cover a lot of stuff..

@webknjaz I wonder if there are any library/apps in wild that do this?

@webknjaz
Copy link
Member

Pip itself used to have py3 and py2 runs both in pre-commit, before 2020. I also do so in some places (like Cheroot). One possible strategy is to test every other version or min/max to cover most stuff while still not using too much resources.
I think that ansible-test runs mypy under every supported interpreter version (both for the ansible-core itself and the external collections).

@webknjaz
Copy link
Member

webknjaz commented Jul 21, 2023

pre-commit tip: if you add several check invocations, it's important to add aliases because several checks have the same id and there's no way to select a specific check without this.

@atugushev
Copy link
Member Author

atugushev commented Jul 21, 2023

I also do so in some places (like Cheroot)

@webknjaz how do you handle type incompatibilities between different versions in the same code?

@atugushev atugushev closed this Jul 21, 2023
@atugushev atugushev reopened this Jul 21, 2023
@atugushev

This comment was marked as resolved.

@atugushev
Copy link
Member Author

FWIW it might be useful to run mypy against several pip and Python versions (like min + max). Just the last one isn't going to cover a lot of stuff..

@webknjaz opened a separate issue #1928 to address the suggestion.

Comment on lines +31 to +33
- click==8.1.6
- pip==23.2
- build==0.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't got these requirements pinned in pyproject.toml - Should we do this, or instead remove the boundary here?

@chrysle chrysle requested a review from webknjaz January 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants