Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow options in config from both pip-compile and pip-sync #1933

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Allow options in config from both pip-compile and pip-sync #1933

merged 6 commits into from
Jul 26, 2023

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jul 24, 2023 •
edited
Loading

Fixes #1932.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added bug Something is not working config Related to pip-tools' configuration labels Jul 24, 2023
@atugushev atugushev changed the title Allow options in config from both pip-compile and pip-sync Allow options in config from both pip-compile and pip-sync Jul 24, 2023
@atugushev atugushev requested a review from chrysle July 25, 2023 19:35
chrysle
chrysle reviewed Jul 25, 2023
View reviewed changes
piptools/utils.py Outdated Show resolved Hide resolved
@chrysle chrysle mentioned this pull request Jul 25, 2023
Merged
4 tasks
chrysle
chrysle reviewed Jul 25, 2023
View reviewed changes
piptools/utils.py Outdated Show resolved Hide resolved
chrysle
chrysle approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@atugushev atugushev merged commit d7885f8 into jazzband:main Jul 26, 2023
34 checks passed
@atugushev atugushev deleted the fix-1932 branch July 26, 2023 08:50
@atugushev
Copy link
Member Author

@chrysle thanks for the review!

@AndydeCleyre
Copy link
Contributor

Does this mean any flags between the two tools will have to be the same value, if the config file is used?

@atugushev
Copy link
Member Author

@AndydeCleyre correct.

@chrysle
Copy link
Contributor

chrysle commented Jul 27, 2023

BTW, I wonder, are separate config sections for the commands (for example [tool.pip-compile]) out of the question?

@atugushev
Copy link
Member Author

@chrysle I wouldn't mind against that.

@atugushev atugushev mentioned this pull request Aug 1, 2023
Closed
@atugushev atugushev added this to the 7.2.0 milestone Aug 2, 2023
@chrysle
Copy link
Contributor

chrysle commented Aug 9, 2023

I'll work on this feature then.

@chrysle chrysle mentioned this pull request Aug 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysle chrysle chrysle approved these changes

Assignees
No one assigned
Labels
bug Something is not working config Related to pip-tools' configuration
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.

pip-compile and pip-sync have different options, but single config section
3 participants
@atugushev @AndydeCleyre @chrysle