Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pip minimum version to >= 23.0 #1971

Closed
wants to merge 2 commits into from
Closed

Bump pip minimum version to >= 23.0 #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d243b90
Remove py37 from tox.ini
apljungquist Aug 20, 2023
edc0b0d
Increase minimum pip version to 23
apljungquist Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ dependencies = [
# direct dependencies
"build",
"click >= 8",
"pip >= 22.2",
"pip >= 23",
Copy link
Member

@atugushev atugushev Aug 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pip >= 23",
"pip >= 23.1",

Usually, when bumping pip version we keep supporting only the two most recent minor versions (undocumented policy discussed in #926). Therefore we can bump the pip up to the 23.1 version.

Could you please also grep all PIP_VERSION mentions and check for any obsolete branches?

"tomli; python_version < '3.11'",
# indirect dependencies
"setuptools", # typically needed when pip-tools invokes setup.py
Expand Down
5 changes: 5 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@
)


def test_can_import_pyproject_hooks():
# TODO: Remove this test when there is code using this package
from pip._vendor import pyproject_hooks # noqa: F401


def test_format_requirement(from_line):
ireq = from_line("test==1.2")
assert format_requirement(ireq) == "test==1.2"
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tox]
envlist =
# NOTE: keep this in sync with the env list in .github/workflows/ci.yml.
py{37,38,39,310,311,312,py3}-pip{previous,latest,main}-coverage
py{38,39,310,311,312,py3}-pip{previous,latest,main}-coverage
pip{previous,latest,main}-coverage
pip{previous,latest,main}
checkqa
Expand All @@ -14,7 +14,7 @@ extras =
testing
coverage: coverage
deps =
pipprevious: pip==22.2.*
pipprevious: pip==23.0.*
piplatest: pip
pipmain: https://github.com/pypa/pip/archive/main.zip
setenv =
Expand Down