-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out origin ireqs for extra requirements before writing output annotations #2011
Filter out origin ireqs for extra requirements before writing output annotations #2011
Conversation
Thanks! Minor note on terms, in the pip-tools context: "header" usually refers to the big comment at the top, while the comments this PR affects are "annotations." |
Right, I don't know what moved me to replicating the mistake ;-) |
Co-authored-by: Sander Van Balen <7672159+sanderr@users.noreply.github.com>
4182dea
to
f6ff30b
Compare
with open(req_in, "w") as req_out: | ||
req_out.write("package-with-extras[extra1,extra2]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: in the future, use the pathlib interface of the tmp_path
fixture.
with open(req_in, "w") as req_out: | |
req_out.write("package-with-extras[extra1,extra2]") | |
req_in.write_text("package-with-extras[extra1,extra2]", encoding="utf-8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint!
@atugushev When do you expect a new release of pip-tools that includes this compatibility fix? |
Same situation here. Solution I found is to rollback pip3 directly on renovate container (if you are using self hosted)
|
Resolves #2003, closes #2007
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.