-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Reduce pip behaviour dependencies in test suite #2105
base: main
Are you sure you want to change the base?
CI: Reduce pip behaviour dependencies in test suite #2105
Conversation
for more information, see https://pre-commit.ci
This reverts commit 2fd6cc6.
This reverts commit bc3f17b.
Given CI is green, I agree it isn't necessary to proceed with this. |
@ncoghlan note that the pip version in CI is now restricted so that the updates are transparent. So it is possible that this breaks with newer pips (I know there are some problems; I just don't know if they are the same you were looking to address here). |
Ah, in that case you will still need something along these lines when upgrading to a newer pip. The specific changes this made are to:
|
This will be an interesting test to see if my changes actually broke compatibility with the older pip version. My prediction: the explicit build system change will be OK, but the protected file list test case will fail (since the older pip still protects those packages) |
Closes #2104
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.