Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools dependency #645

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

vphilippon
Copy link
Member

@vphilippon vphilippon commented Mar 23, 2018

Setuptools is still required for pip-sync if pip needs it,
but pip-tools code itself doesn't require it anymore.
A pip-compile can be completed without setuptools.

Changelog-friendly one-liner: Removed the hard dependency on setuptools.

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

setuptools is still required for pip-sync if pip needs it, but pip-tools
code iteself doesn't require it anymore.
Copy link
Contributor

@davidovich davidovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vphilippon vphilippon merged commit 56d0301 into jazzband:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants