Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply version constraints specified with package upgrade option #694

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented Oct 23, 2018

  1. In order to get tests passing for me locally (prior to any new features/fixes), I had to update them to handle a user pipconf with a non-default index url, since the generated requirements text includes it, and the tests didn't expect it. If you'd rather I split this into a separate PR or fix it differently, let me know.
  2. No longer ignore version constraints provided with the --upgrade-package option (For Upgrade specific package to a specific version fails to pick up the version constraint #649). The test I added requires a new binary wheel in the test data. I saw existing wheels there, but I'm not sure how they were generated, so I copied the contents of an existing one. Thus, the version in the wheel's contents is incorrect. Please let me know the best way to generate this test data!

Changelog-friendly one-liner: Apply version constraints specified with package upgrade option

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

@vphilippon vphilippon self-requested a review November 16, 2018 20:59
@vphilippon vphilippon added this to the 3.2.0 milestone Nov 16, 2018
Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @richafrank, thanks for the contribution!

For the test wheel, the easiest way would be to write a simple setup.py like this:

from setuptools import setup

setup(
    name='small-fake-b',
    version='0.3',
)

then run python setup.py bdist_wheel --universal --dist-dir ./ to generate the wheel in the current directory.

For the change itself, LGTM 👍

@richafrank
Copy link
Contributor Author

Thanks @vphilippon! I updated the test wheel.

@vphilippon
Copy link
Member

Thanks @richafrank for the contribution, it's really appreciated :)

@vphilippon vphilippon merged commit c1b4c67 into jazzband:master Nov 22, 2018
@richafrank
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants