Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --allow-unsafe to update instructions #708

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

richafrank
Copy link
Contributor

Prior to this change, running pip-compile with --allow-unsafe affected the output file, in that setuptools et al would become uncommented. However, the output file's instructions on what command to re-run to produce it did not include --allow-unsafe, so setuptools would end up commented out again. See #664

This PR includes that flag in the instructions in the output file's header.

Changelog-friendly one-liner: Add --allow-unsafe to update instructions

cc @vphilippon as a reviewer

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

since it impacts whether certain packages are commented out in
the output file.
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Have a couple of minor comments though.

piptools/writer.py Outdated Show resolved Hide resolved
tests/test_writer.py Outdated Show resolved Hide resolved
@atugushev atugushev merged commit 19d59cf into jazzband:master Jan 15, 2019
@atugushev
Copy link
Member

@richafrank thanks!

@richafrank
Copy link
Contributor Author

Great - thanks @atugushev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants