Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent to uninstall stdlib and dev packages #718

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

atugushev
Copy link
Member

Fixes #690.

Changelog-friendly one-liner: Prevent to uninstall stdlib and dev packages

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

piptools/sync.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #718 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   85.17%   85.18%   +<.01%     
==========================================
  Files          31       31              
  Lines        2064     2065       +1     
  Branches      309      309              
==========================================
+ Hits         1758     1759       +1     
  Misses        235      235              
  Partials       71       71
Impacted Files Coverage Δ
tests/test_sync.py 98.21% <ø> (ø) ⬆️
piptools/sync.py 78.94% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a5b4d...7c46006. Read the comment docs.

piptools/sync.py Outdated Show resolved Hide resolved
@atugushev atugushev force-pushed the fix-uninstall-stdlib-packages branch from 688905b to 4dd6edb Compare January 24, 2019 13:14
@atugushev atugushev force-pushed the fix-uninstall-stdlib-packages branch from 4dd6edb to 7c46006 Compare January 24, 2019 21:00
@atugushev
Copy link
Member Author

@blueyed @suutari-ai
Guys, i've squashed commits into one. PR is ready to merge, if you approve it.

@vphilippon vphilippon added this to the 3.3.2 milestone Jan 24, 2019
@atugushev atugushev merged commit 49efbec into jazzband:master Jan 24, 2019
@atugushev
Copy link
Member Author

Thank you @vphilippon!

@atugushev atugushev deleted the fix-uninstall-stdlib-packages branch January 25, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants