Fix a regression bug came from #731 PR #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pip-compile setup.py --output-file=output.txt` ignores `--output-file` option and compiles to a `requirements.txt` file.
blueyed
approved these changes
Feb 28, 2019
|
|
||
| out = runner.invoke(cli, options) | ||
| assert out.exit_code == 0 | ||
| assert os.path.exists(expected_output_file) |
There was a problem hiding this comment.
Just a nitpick: the asserts could be dedented.
There was a problem hiding this comment.
Agreed. Let's clean it up in a following PR.
There was a problem hiding this comment.
In addition to that, i would also make the runner a fixture and clean up all the tests (which use the runnrt) like this one: https://github.com/jazzband/pip-tools/blob/67edc7d227507f3902090d2db8e129715279ae04/tests/test_cli_compile.py#L442-L449
IMO the tests look more concise in that way, so let's take advantages of the magnificent pytest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
pip-compile setup.py --output-file=output.txtignores--output-fileoption and compiles to arequirements.txtfile.Refs #731.