-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write markers before hashes to fix issues. #763
Write markers before hashes to fix issues. #763
Conversation
@atugushev Please review when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the bug! Could you provide a test something like test_format_requirement_ireq_with_hashes_and_markers
?
6d02128
to
09e62cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 35 35
Lines 2296 2296
Branches 306 306
=======================================
Hits 2111 2111
Misses 153 153
Partials 32 32
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 91.94% 91.96% +0.02%
==========================================
Files 35 35
Lines 2296 2302 +6
Branches 306 306
==========================================
+ Hits 2111 2117 +6
Misses 153 153
Partials 32 32
Continue to review full report at Codecov.
|
@atugushev added test. |
@milind-shakya-sp it looks good now. Could you please change the Changelog-friendly one-liner, because the issue number will be attached anyway. |
@atugushev updated. |
Thanks for the contribution! |
|
Fixes issue with generated lock file when hashes and markers are used together.
Fixes #762
Changelog-friendly one-liner: Fix order issue with generated lock file when hashes and markers are used together.
Contributor checklist