Drop python 3.4

[auvipy]

Remove py34 from:

• setup
• tox
• appveyour
• travis

[atugushev]

Hello @auvipy,

Thank you for the contribution! I would rather not to drop the support. I think we should wait at least a pip release (it should be right after 19.1) with dropped support of the python 3.4 and after, we could drop the support and make a release for the pip-tools.

But since we have already removed the support in #804 and #805 (why they are not approved, but merged by the way, @auvipy?) my concerns may not reasonable anymore.

@vphilippon @blueyed what do you think?

[auvipy]

https://github.com/pypa/pip/releases/tag/19.1 is already on the wild 💃

[atugushev]

https://github.com/pypa/pip/releases/tag/19.1 is already on the wild 💃

19.1 still supports 3.4 with a deprecation warning and support will gone since 19.2.

[auvipy]

Hello @auvipy,

Thank you for the contribution! I would rather not to drop the support. I think we should wait at least a pip release (it should be right after 19.1) with dropped support of the python 3.4 and after, we could drop the support and make a release for the pip-tools.

But since (as i can see in the master branch) we have already removed the support in #804 and #805 (why they are not approved, but merged by the way, @auvipy?) my concerns may not reasonable anymore.

@vphilippon @blueyed what do you think?

IMHO, as it's not breaking anything and a very trivial valid change, these shouldn't go through the full formal process always, since practicality beats purity. And we can revert again if that creates a problem. but I didn't merge anything with Red Button 🗡️

[codecov]

Codecov Report

Merging #803 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          35       35           
  Lines        2050     2050           
  Branches      262      262           
=======================================
  Hits         2025     2025           
  Misses         15       15           
  Partials       10       10

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45998a...ab39ec4. Read the comment docs.

[codecov]

Codecov Report

Merging #803 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
- Coverage   98.78%   98.77%   -0.01%     
==========================================
  Files          35       35              
  Lines        2050     2044       -6     
  Branches      262      262              
==========================================
- Hits         2025     2019       -6     
  Misses         15       15              
  Partials       10       10

Impacted Files	Coverage Δ
tests/test_utils.py	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45998a...ab39ec4. Read the comment docs.

[atugushev]

@auvipy

IMHO, as it's not breaking anything and a very trivial valid change, these shouldn't go through the full formal process always, since practicality beats purity. And we can revert again if that creates a problem. but I didn't merge anything with Red Button

It's not a problem, but I would prefer to be more collaborative (even on trivial changes) :) See also jazzband/help#121 (comment).

PS
It's been forgotten to drop support from appveyour, so i've fixed it.

PPS
But i still think we should drop support after pip==19.2 release.

[auvipy]

I do agree with you buddy!

[atugushev]

I've removed the current milestone to prepare new release.

[auvipy]

that's alright

[atugushev]

Since we drop 3.4 support i'd suggest to bump major version.

[atugushev]

pip-tools v4.0.0 is released.