-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip>=19.2 compatibility #857
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
=========================================
+ Coverage 98.85% 99.06% +0.2%
=========================================
Files 36 35 -1
Lines 2191 2147 -44
Branches 285 284 -1
=========================================
- Hits 2166 2127 -39
+ Misses 15 12 -3
+ Partials 10 8 -2
Continue to review full report at Codecov.
|
0f65f7d
to
ffeb284
Compare
Fix coverage decreasing
Turns out Command._build_package_finder avaiable since 8.1.1
Finally it's all green! @vphilippon @blueyed kindly ping you guys, review it please if you have a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not looked too closely, but given that CI will like it I think it's good!
Thanks!
|
Closes #856.
TODO
piptools/pip.py
and tests with get_pip_commandpip-tools
Changelog-friendly one-liner: Fix pip>=19.2 compatibility
Contributor checklist
Refs #853.