Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dry-run log message from being printed with --quiet option #861

Merged
merged 7 commits into from
Aug 12, 2019

Conversation

ddormer
Copy link
Contributor

@ddormer ddormer commented Jul 29, 2019

Changed the log level for the message "Dry-run, so nothing updated." from warning to info.

Refs #845

Changelog-friendly one-liner: Prevent --dry-run log message from being printed with --quiet option.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@ddormer
Copy link
Contributor Author

ddormer commented Jul 29, 2019

I'm not overly happy with tests needing to handle a ValueError raised from Click but I didn't want to touch the Click Result instance variables. Perhaps someone has a better alternative?

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #861 into master will decrease coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   99.06%   98.84%   -0.23%     
==========================================
  Files          35       35              
  Lines        2142     2158      +16     
  Branches      284      284              
==========================================
+ Hits         2122     2133      +11     
- Misses         12       15       +3     
- Partials        8       10       +2
Impacted Files Coverage Δ
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️
piptools/repositories/pypi.py 92.55% <0%> (-2.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520c742...86dfdc4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #861 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   99.06%   98.93%   -0.14%     
==========================================
  Files          35       35              
  Lines        2142     2152      +10     
  Branches      284      284              
==========================================
+ Hits         2122     2129       +7     
- Misses         12       14       +2     
- Partials        8        9       +1
Impacted Files Coverage Δ
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️
piptools/repositories/pypi.py 93.61% <0%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520c742...fba810d. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ddormer,

Thanks for the contribution! Could you please fix several issues in tests?

tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
@atugushev
Copy link
Member

By the way it also refs to #845 and partially fixes it.

@atugushev atugushev added enhancement Improvements to functionality bug fix and removed enhancement Improvements to functionality labels Aug 2, 2019
@ddormer
Copy link
Contributor Author

ddormer commented Aug 12, 2019

Thanks for the review @atugushev. Sorry this took so long to get back to, I was on holiday the past week.

@atugushev atugushev added this to the 4.0.1 milestone Aug 12, 2019
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts! LGTM 👍

@atugushev atugushev merged commit 903931f into jazzband:master Aug 12, 2019
@atugushev atugushev modified the milestones: 4.0.1, 4.1.0 Aug 14, 2019
@ddormer ddormer deleted the 845-quiet-dry-run branch August 16, 2019 07:46
@atugushev
Copy link
Member

pip-tools v4.1.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants