-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info to README about layered requirements files #905
Add info to README about layered requirements files #905
Conversation
This is broken because master is broken 😞 Latest PR that seems to have introduced the breakage is here: #864 Bump me when master is green again and I can merge the fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution! Please, consider grammar comments as minor, for I'm not a native speaker.
Looks like I've forgotten to mark |
Co-Authored-By: Albert Tugushev <albert@tugushev.ru>
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
- Coverage 99.06% 98.57% -0.49%
==========================================
Files 35 35
Lines 2247 2247
Branches 288 288
==========================================
- Hits 2226 2215 -11
- Misses 13 21 +8
- Partials 8 11 +3
Continue to review full report at Codecov.
|
Co-Authored-By: Albert Tugushev <albert@tugushev.ru>
@atugushev Thanks for all the suggestions - I've merged them all in. Just waiting for the master fix now (#906) 👍 |
Thanks for addressing my review comments! Could you please also add a "Changelog-friendly one-liner" to the issue text? |
@atugushev NP. Thanks for helping me on this PR 👍 I have added the one-liner to the description - hope it's suitable. |
Great! I'm going to merge this, despite failing CI, since the TOXENV=readme CI job is green. |
@jamescooke thank you so much for working on this! Appreciate it! |
Hopefully fixes #398 🤞
Changelog-friendly one-liner: Add info to README about layered requirements files and
-c
flagContributor checklist
Not sure how to address these - sorry...
Provided the tests for the changes.