Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pip-compile --upgrade-package removes "via" annotation #931

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Oct 9, 2019

Fixes #929.

Changelog-friendly one-liner: Fixed pip-compile --upgrade-package removes "via" annotation.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev
Copy link
Member

Hello @hramezani,

Thanks for fixing this bug and the test! Could you use current PR template if the changes are user-facing, for it might need a changelog entry? Thanks!

@hramezani
Copy link
Member Author

Hello @hramezani,

Thanks for fixing this bug and the test! Could you use current PR template if the changes are user-facing, for it might need a changelog entry? Thanks!

@atugushev Thanks for the comment. Description edited.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #931 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   99.09%   99.09%   +<.01%     
==========================================
  Files          35       35              
  Lines        2321     2331      +10     
  Branches      300      301       +1     
==========================================
+ Hits         2300     2310      +10     
  Misses         13       13              
  Partials        8        8
Impacted Files Coverage Δ
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ab384...e5fa62d. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few nit-pickings below 🤓

tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
@atugushev atugushev changed the title Fixed pip-compile --upgrade-package removes "via" annotationi problem. (issue #929) Fixed pip-compile --upgrade-package removes "via" annotation Oct 9, 2019
@atugushev
Copy link
Member

Thanks for addressing to my request changes, i've marked all conversations as resolved!

@atugushev atugushev added this to the 4.2.0 milestone Oct 9, 2019
tests/test_cli_compile.py Outdated Show resolved Hide resolved
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@atugushev atugushev merged commit bba7331 into jazzband:master Oct 10, 2019
@atugushev
Copy link
Member

Thanks for your excellent work and your patience, @hramezani!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile --upgrade-package removes "via" annotation from lock file
2 participants