Add python 3.8 support

[hramezani]

Closes #948.

Changelog-friendly one-liner: Added python 3.8 support.

Contributor checklist

• Provided the tests for the changes.
• Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
• Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

[atugushev]

@hramezani

Changelog-friendly one-liner:

it looks empty, could you uncomment the text after the label?

[codecov]

Codecov Report

Merging #956 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #956      +/-   ##
=========================================
+ Coverage   98.97%   99.1%   +0.12%     
=========================================
  Files          34      34              
  Lines        2350    2350              
  Branches      305     305              
=========================================
+ Hits         2326    2329       +3     
+ Misses         13      11       -2     
+ Partials       11      10       -1

Impacted Files	Coverage Δ
piptools/repositories/pypi.py	93% <0%> (+1.5%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a3eb1...4b910e3. Read the comment docs.

[hramezani]

@atugushev Thanks for the comment.
Check them again please and let me know if something is missed.

[atugushev]

@hramezani thanks for addressing my review comments! Let's see how's the CI goes.

[atugushev]

@hramezani could you also move py38-piplatest to the baseline tests group?

[atugushev]

@hramezani py38-pip8.1.1 is failing, but I can't reproduce it locally. Can you?

[hramezani]

py38-pip8.1.1

platform.linux_distribution() is removed in python3.8. and pip8.1 uses it:

File "/home/hasan/work/jazzband/pip-tools/.tox/py38-pip8.1.1/lib/python3.8/site-packages/pip/download.py", line 93, in user_agent
 34     zip(["name", "version", "id"], platform.linux_distribution()),

[atugushev]

@hramezani

platform.linux_distribution() is remove in python3.8. and pip8.1 uses it:

File "/home/hasan/work/jazzband/pip-tools/.tox/py38-pip8.1.1/lib/python3.8/site-packages/pip/download.py", line 93, in user_agent
 34     zip(["name", "version", "id"], platform.linux_distribution()),

Yes, indeed, https://bugs.python.org/issue28167. Thanks! Let's exclude this job from the matrix then.

[hramezani]

@atugushev Do you have any idea about why some AppVeyor tests failed?

[atugushev]

@hramezani

Do you have any idea about why some AppVeyor tests failed?

It might be an issue with codecov. I've restarted failed jobs.

[hramezani]

Seems they have not prepared python 3.8
SKIPPED: py38-pip19.2.3-coverage: InterpreterNotFound: python3.8

[atugushev]

Yeah, we have to wait the following issues being closed:

• Python 3.8.0 appveyor/ci#3142
• Add Python 3.8 support actions/setup-python#30

[atugushev]

FTR, GitHub Actions has now fully support Python 8, see actions/setup-python#30 (comment).

[atugushev]

FTR, AppVeyor has deployed Python 3.8, see appveyor/ci#3142 (comment).

[atugushev]

Reopened to trigger CIs.

[atugushev]

Huh, we need to fix #983 first...

[atugushev]

@hramezani could you merge the latest master? The issue #983 is fixed.

[hramezani]

@atugushev Thanks. finally, it passed.

[atugushev]

LGTM 👍

[atugushev]

@hramezani thank you so much!