Call LocalRequirementsRepository.allow_all_wheels() in tests #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a copy-paste issue, since there should be called `local_repository.allow_all_wheels()` context manager, which yields `local_repository.repository.allow_all_wheels()`.
|
Hey, sorry, I really don't remember this code at all! |
No worries! Thanks for the quick response! Really appreciate it 👍 |
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 99.18% 99.27% +0.08%
==========================================
Files 35 35
Lines 2338 2338
Branches 301 301
==========================================
+ Hits 2319 2321 +2
+ Misses 11 9 -2
Partials 8 8
Continue to review full report at Codecov.
|
webknjaz
approved these changes
Oct 24, 2019
|
@webknjaz thank you for taking the time to review this! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a copy-paste issue, since there should be called
local_repository.allow_all_wheels()context manager, which yields btwrepository.allow_all_wheels().Increases test coverage.