Cleanup ephemeral wheel cache properly #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atugushev
force-pushed
the
cleanup-wheel-cache
branch
from
045c854
to
fd8b573
Compare
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 99.1% 99.11% +<.01%
==========================================
Files 34 34
Lines 2357 2362 +5
Branches 305 306 +1
==========================================
+ Hits 2336 2341 +5
Misses 11 11
Partials 10 10
Continue to review full report at Codecov.
|
atugushev
changed the title
atugushev
force-pushed
the
cleanup-wheel-cache
branch
3 times, most recently
from
d830e8b
to
0e3ef2c
Compare
webknjaz
reviewed
Oct 25, 2019
codingjoe
reviewed
Oct 26, 2019
Attribute `self.wheel_cache` has been removed in f6de247, thus `self.wheel_cache.cleanup()` will allways throw the AttributeError and `wheel_cache.cleanup()` will never be called as supposed to be. WheelCache.cleanup() has been introduced in `pip==10.0.0`. It's better to check pip version explicitly (LBYL) rather than ask for forgiveness (EAFP).
atugushev
force-pushed
the
cleanup-wheel-cache
branch
from
0e3ef2c
to
40d74a6
Compare
|
ℹ️ rebased onto master and resolved conflicts. |
|
@webknjaz, @codingjoe and @suutari, thanks for reviewing this! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute
self.wheel_cachehas been removed in f6de247, thusself.wheel_cache.cleanup()will allways throw:and
wheel_cache.cleanup()will never be called as supposed to be.WheelCache.cleanup() has been introduced in
pip==10.0.0. Try-except block has been refactored, for it's better to check the pip version explicitly (LBYL) rather than ask for forgiveness (EAFP).Changelog-friendly one-liner: Fix dependency resolver to clean up the ephemeral wheel cache.
Contributor checklist