-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testing from Travis CI to GitHub Actions #479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 28 28
Lines 2613 2613
=======================================
Hits 2369 2369
Misses 244 244 Continue to review full report at Codecov.
|
I'm not so thrilled to add even more dependencies on Github. I don't see Travis limitation a problem for our usage, do you? |
Unfortunately yes, others and I are seeing big problems with Travis CI.
First, travis-ci.org has been really slow (maybe we were lucky just now, on a Saturday) with long delays of sometimes up to an hour before jobs begin. That's because they've been moving resources from .org to travis-ci.com, and everything will need to be moved to travis-ci.com by the end of the year, when .org will be closed down. Second, there's a new credit-based pricing model on .com. They give a 10k-credit free trial, enough for 1k Linux minutes. When that expires they encourage you to buy a plan or ask to be on some new OSS plan, where if the project meets the requirements, they will evaluate how many credits the project can have. It's not clear if this renews monthly or if the process must be repeated when the credits expire. I've applied for credits for another project but not got very far yet. Some more info here: |
Thanks so much for this detailed report. I would not rush however in changing things, firstly because tablib does not see so much activity (we can affort waiting 1-2 hours for tests) and Travis may react to the Web feedback at some point. |
Okay, let's wait a bit. I'll make a new PR with the first commit (GHA coverage) and third (fix pytest warning), they're still useful now. Edit: #480. |
(Rebased after merging subset #480.) |
All Jazzband repos need porting over to GHA: |
The alternatives of course are Azure, GitLab, Circle CI and a few others. Given the fact that GitHub Actions are designed to allow self-hosted test runners I'd say the risk of lock-in is manageable compared to the added benefits of direct integration in the GitHub development workflow. Luckily there is https://github.com/ymyzk/tox-gh-actions so the migration of all projects should be relatively straight-forward. |
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, let's do the same.
We already have tests on GHA, just missing sending coverage to Codecov. Earlier it was tricky to do, but Codecov now have an action for this; added here.Done in #480.We'll need to move deployment from Travis to GHA. We already got it working for another Jazzband project, but I'll do it in a followup PR.
So this one reduces the Travis testing to a single job.
This also fixes a pytest warning:Done in #480.