Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some IDE warnings #559

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Clean up some IDE warnings #559

merged 9 commits into from
Aug 2, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 2, 2023

Some cleanup to remove some warnings shown in PyCharm.

See commit messages for details.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #559 (3f74f1c) into master (f3ef2e9) will increase coverage by 0.22%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   91.37%   91.59%   +0.22%     
==========================================
  Files          28       28              
  Lines        2713     2785      +72     
==========================================
+ Hits         2479     2551      +72     
  Misses        234      234              
Files Changed Coverage Δ
src/tablib/formats/_xlsx.py 100.00% <ø> (ø)
src/tablib/packages/dbfpy/dbfnew.py 97.67% <ø> (ø)
src/tablib/__init__.py 60.00% <100.00%> (ø)
src/tablib/core.py 85.01% <100.00%> (ø)
src/tablib/formats/__init__.py 95.45% <100.00%> (ø)
src/tablib/formats/_dbf.py 100.00% <100.00%> (ø)
src/tablib/formats/_df.py 75.00% <100.00%> (ø)
src/tablib/formats/_html.py 100.00% <100.00%> (ø)
src/tablib/formats/_latex.py 100.00% <100.00%> (ø)
src/tablib/formats/_ods.py 98.18% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hugovk hugovk merged commit d4e68c6 into jazzband:master Aug 2, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants