26.memory leaks #27
Merged
26.memory leaks #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also removes the `@exit_after` decorator and moves it to its own method. closes jbaiter#21
|
I forgot to move the Sorry I didn't catch that until now... Whoops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does solve the memory leaks for
capture()completely, that's been a little difficult to track down the full culprit, but this does improve them just a tiny bit. I suspect something might be happening with theffi.cast()calls as well. There could also be something in CFFI itself too.I also included fixes for
get_preview(). I removed it's@exit_afterdecorator and added a newexit()method that the programmer can call instead to get out of the preview mode.Version number was also bumped to
0.4.2