Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First wave of refactoring #16

Closed
wants to merge 7 commits into from
Closed

Conversation

willprice
Copy link

This resolves #13, have started adding tests to verify correct behaviour of module

Will Price and others added 7 commits August 10, 2014 21:21
- Refactored parsing code out to a separate class
- Added a smoke test that runs an example MP4 to make sure initial refactorings didn't break (much) behaviour
…seems the best method to get rough seconds elapsed. Also set initial position to 0 to prevent position not being a property on self if checked too soon externally.
Fixed the 'omxplayer -s' stats regex to use the time from the audio, …
@willprice willprice closed this Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor code to separate parsing responsibilities
2 participants