Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy evaluation of extractor values for ThymeleafTemplateEngine #471

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

ancho
Copy link
Member

@ancho ancho commented Jul 17, 2018

I noticed a strange behaviour baking a site using thymeleaf template engine.
https://gitlab.com/devlug/devlug-web

It was awful slow.

08:28:18.835 INFO  org.jbake.app.Oven - Baking finished!
08:28:18.835 INFO  org.jbake.app.Oven - Baked 86 items in 15048ms

I took a look at the memory consumption with visualvm.
heap-space-jbake-thyme-before

When it hits the 500 MB mark the rendering process starts.

With the applied fix the overall bake time goes down do nearly 8 sec.

08:38:40.496 INFO  org.jbake.app.Oven - Baking finished!
08:38:40.496 INFO  org.jbake.app.Oven - Baked 86 items in 7894ms

And the memory consumption looks much better, too.

heap-space-jbake-thyme-after

I had to update the gradle wrapper as bintray dropped TLS 1.0/1.1 support, which caused the java 7 build to fail on travis and appveyor. See https://jfrog.com/knowledge-base/why-am-i-failing-to-work-with-jfrog-saas-service-with-tls-1-0-1-1/

An update to orientdb slipped into this pr. Shall I revert it?

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.8%) to 73.272% when pulling 8f0ac69 on ancho:feature/fix-thymeleaf-memory-leak into a402b14 on jbake-org:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.8%) to 73.272% when pulling 8f0ac69 on ancho:feature/fix-thymeleaf-memory-leak into a402b14 on jbake-org:master.

@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage decreased (-0.5%) to 80.732% when pulling 44161a7 on ancho:feature/fix-thymeleaf-memory-leak into 4f3a18a on jbake-org:master.

Copy link
Member

@jonbullock jonbullock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that's quite an improvement. The changes looks fine to me and the upgrade to OrientDB is OK too.

@jonbullock jonbullock added this to the v2.6.2 milestone Aug 6, 2018
@ancho ancho force-pushed the feature/fix-thymeleaf-memory-leak branch from 8f0ac69 to 44161a7 Compare August 14, 2018 08:29
@ancho ancho merged commit 278e6ea into jbake-org:master Aug 14, 2018
@ancho ancho deleted the feature/fix-thymeleaf-memory-leak branch May 1, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants