Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build.jbang support #28

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Sep 5, 2022

Signed-off-by: Fred Bricon fbricon@gmail.com

@fbricon fbricon marked this pull request as ready for review September 5, 2022 07:28
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #28 (83ee42a) into main (0939669) will increase coverage by 0.83%.
The diff coverage is 56.00%.

@@             Coverage Diff              @@
##               main      #28      +/-   ##
============================================
+ Coverage     48.74%   49.58%   +0.83%     
- Complexity      257      270      +13     
============================================
  Files            43       43              
  Lines          1637     1688      +51     
  Branches        254      266      +12     
============================================
+ Hits            798      837      +39     
  Misses          722      722              
- Partials        117      129      +12     
Flag Coverage Δ
Linux 49.58% <56.00%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/internal/classpath/AnnotationProcessorUtils.java 6.41% <ø> (ø)
...core/internal/expressions/JBangResourceTester.java 0.00% <0.00%> (ø)
...e/core/internal/imports/ImportJBangScriptsJob.java 0.00% <0.00%> (ø)
...pse/core/internal/project/SynchronizeJBangJob.java 0.00% <0.00%> (ø)
...ang/eclipse/core/internal/JBangClasspathUtils.java 22.64% <36.36%> (+4.03%) ⬆️
...ev/jbang/eclipse/core/internal/JBangFileUtils.java 38.75% <38.09%> (+11.98%) ⬆️
...eclipse/core/internal/utils/ImportScriptUtils.java 89.47% <50.00%> (+0.58%) ⬆️
.../internal/project/ProjectConfigurationManager.java 71.37% <61.53%> (-0.85%) ⬇️
...ng/eclipse/core/internal/builder/JBangBuilder.java 69.23% <76.92%> (+0.55%) ⬆️
.../jbang/eclipse/core/internal/ImportScriptTest.java 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon merged commit 3b57d28 into jbangdev:main Sep 5, 2022
@fbricon
Copy link
Collaborator Author

fbricon commented Sep 5, 2022

Partially addresses #25. Still need to figure out why, in JDT.LS, autosync doesn't work and diagnostics are not reported on build.jbang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant