Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config set/remove should tell what file it edits #1188

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

maxandersen
Copy link
Collaborator

@maxandersen maxandersen commented Jan 9, 2022

fixes #1184

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #1188 (fc4f563) into main (fd729a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1188   +/-   ##
=========================================
  Coverage     59.06%   59.06%           
  Complexity     1052     1052           
=========================================
  Files            84       84           
  Lines          5572     5572           
  Branches        936      936           
=========================================
  Hits           3291     3291           
  Misses         1798     1798           
  Partials        483      483           
Flag Coverage Δ
Linux 57.89% <100.00%> (ø)
Windows 57.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/jbang/cli/Config.java 48.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd729a1...fc4f563. Read the comment docs.

Copy link
Contributor

@quintesse quintesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxandersen maxandersen merged commit df9976f into jbangdev:main Jan 12, 2022
@maxandersen maxandersen deleted the configinformative branch January 12, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jbang config set/unset etc. should tell what configuration it updated
2 participants