Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jbang-vscode to codium + add usability vscode settings #1427

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

maxandersen
Copy link
Collaborator

jbang-vscode is still in preview mode but it is too good to not be enabled imo.

plus i realized vscodium defaults are slightly bad so added a few default settings
such as autosave on, zoom by trackpad/mousewheel, linked editing and method name guesing.


String vscodeSettings = "{\n" +
// better than breadcrumbs
" \"editor.experimental.stickyScroll.enabled\": true,\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work well with Java code. Try a file with a copyright header, or annotations

@fbricon
Copy link
Contributor

fbricon commented Aug 10, 2022

will it still generate the eclipse project files?

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1427 (e2fd199) into main (3af66d9) will decrease coverage by 0.05%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##               main    #1427      +/-   ##
============================================
- Coverage     57.35%   57.29%   -0.06%     
  Complexity     1218     1218              
============================================
  Files           104      104              
  Lines          6317     6323       +6     
  Branches       1035     1036       +1     
============================================
  Hits           3623     3623              
- Misses         2209     2215       +6     
  Partials        485      485              
Flag Coverage Δ
Linux 56.11% <14.28%> (-0.06%) ⬇️
Windows 56.69% <14.28%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/jbang/cli/Edit.java 44.12% <14.28%> (-1.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@maxandersen
Copy link
Collaborator Author

will it still generate the eclipse project files?

for now yes; but my thinking is that in futureif you do jbnag edit it_wont, but for jbang edit xyz.java it will continue to do the linked trick as it works more places out of box.

@fbricon
Copy link
Contributor

fbricon commented Aug 10, 2022

that means if you open a jbang script it'll first be imported as an eclipse project. Dependency validation will require clicking on the Synchronize JBang code lens

@maxandersen
Copy link
Collaborator Author

yes, but users using codium from command line will enjoy it.

@maxandersen maxandersen merged commit 37b6781 into jbangdev:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants