fix: alias settings not being properly applied #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quintesse
force-pushed
the
fix_alias
branch
from
79caf95
to
90a1a57
Compare
This fixes for example the issue where setting the "java" option didn't actually do anything.
These tests the main ways a project can be built: from a source file, from a JAR or from a GAV. In all three cases we also test their options being overridden by aliases.
quintesse
force-pushed
the
fix_alias
branch
from
b7a6a3c
to
8813727
Compare
|
@maxandersen ready to be merged. The fix is small , most of this PR is tests. |
|
What is it fixing? |
|
The fact that some alias settings were not being applied. Like the one from your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.