Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the custom debug port when provided #1690

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: use the custom debug port when provided #1690

merged 1 commit into from
Oct 2, 2023

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Oct 2, 2023

fixes #1689

Motivation

When a custom debug port is provided thanks to the parameter --debug, the port 4004 is still used.

Modifications:

  • Ensure that the default values including the port can be redefined by the end user
  • Add a unit test to cover the use case

quintesse
quintesse approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@quintesse quintesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@essobedo
Copy link
Contributor Author

essobedo commented Oct 2, 2023

@maxandersen hi, any feedbacks to provide regarding my PR?

@maxandersen
Copy link
Collaborator

Sorry hadn't seen that fix! Same as the one I found so for sure let's use this one!

@maxandersen maxandersen merged commit d0d2a49 into jbangdev:main Oct 2, 2023
11 checks passed
@essobedo essobedo deleted the 1689/use-custom-debug-port branch October 2, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quintesse quintesse quintesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom debug port not taken into account
3 participants
@essobedo @maxandersen @quintesse