-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'WithSetters' proc_macro_derive, change version to 0.2.0 #97
base: main
Are you sure you want to change the base?
Conversation
@jbaublitz Yes, it is the same requirement, but the implementation is more in line with Rust specifications and more complete and reliable than that of #84. |
@jbaublitz After waiting for a long time without result, I have independently published it to getset2. |
@musjj I have finally been catching up on a backlog of issues over on my other crate I maintain, neli. I just got a release out for that containing some bug fixes that I've been sitting on for a while, so I'm going to shift my focus to getset and try to make my way backwards through the pull requests and then the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the code and just have one comment. Other than that, this looks good and I'd be willing to merge and put out a new release.
@@ -5,8 +5,11 @@ Getset, we're ready to go! | |||
A procedural macro for generating the most basic getters and setters on fields. | |||
""" | |||
version = "0.1.3" | |||
authors = ["Ana Hobden <ana@hoverbear.org>", "John Baublitz <john.m.baublitz@gmail.com"] | |||
version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a breaking change that I'm missing? I believe this is an added feature which, pre-1.0.0, does not need a minor version bump.
fn_name
iswith_{field_name}
Demonstration of usage scenarios: