Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim start point #16

Closed
alanquigley opened this issue Jun 10, 2015 · 13 comments
Closed

trim start point #16

alanquigley opened this issue Jun 10, 2015 · 13 comments

Comments

@alanquigley
Copy link

Is it possible to set a trim start point with the plugin?

@rossmartin
Copy link
Collaborator

Not yet but I plan on adding that. Will update this when it is added.

Thanks.

@alanquigley
Copy link
Author

Hi Ross, we added already on our fork. We've also added server other functions such as frame sequences.

@srinivasulurao
Copy link

@alanquigley can i have the code or any documentation for start time /End time functionality.

@alanquigley
Copy link
Author

@srinivasulurao
Copy link

@alanquigley thanks a lot, what parameter do i need to pass for start time ?

@alanquigley
Copy link
Author

execVideoEditor('trim', videoID, {
  inputFile       : inputID,
  outputFileName  : output,
  trimStart       : 1,
  trimEnd         : 5
})

Should be something like that, very much tailored to work with our internal
data model, but you should be able to glean from the code the correct
approach.

On 10 November 2015 at 10:23, N.Srinivasulu Rao notifications@github.com
wrote:

@alanquigley https://github.com/alanquigley thanks a lot, what
parameter do i need to pass for start time ?


Reply to this email directly or view it on GitHub
#16 (comment)
.

@srinivasulurao
Copy link

@alanquigley awesome, i have one last question with this, can we assign the quality option as well, just like we had in the jbavari plugin.

@alanquigley
Copy link
Author

Not sure, try it :)

On 10 November 2015 at 12:11, N.Srinivasulu Rao notifications@github.com
wrote:

@alanquigley https://github.com/alanquigley awesome, i have one last
question with this, can we assign the quality option as well, just like we
had in the jbavari plugin.


Reply to this email directly or view it on GitHub
#16 (comment)
.

@rossmartin
Copy link
Collaborator

@alanquigley Thank you for the additions on the plugin. I added the trim functionality your team created for the ios/android version.

@srinivasulurao

You can now trim a video in the latest version (0.0.6) of the plugin -

https://github.com/jbavari/cordova-plugin-video-editor/tree/0.0.6#trim-a-video

@srinivasulurao
Copy link

@rossmartin iam getting an error, trim: failed to trim video, the transcoding was working nicely but not the trim, can u please help me for this.

@srinivasulurao
Copy link

@rossmartin seems like the execFFMPEG function is not trimming the video, can u please help me out for this quickly, i have told my client already that the the trimming is working.

@rossmartin
Copy link
Collaborator

@srinivasulurao Are you testing on real android device or emulator?

Does the shotclip-team fork work for you? I am using their exact same code they added for trimming but the inputFile parameter is fileUri. Trim is working for me on my Galaxy S2 on 4.2.2

@srinivasulurao
Copy link

@rossmartin the shortclip-team fork gave me the same error which iam getting now, i am using a real android device, i somehow made it working, in the videoeditor.java file i found that that file extension is coming as something like this ".document/data/data" it should come as ".mp4" or any other format while storing inside the tempDir, Secondly we should use the external memory path for the storage of the video after trimming, just like you did in the transcoding which was perfectly coded, right now it is storing in a cache folder.

Also is there any way to get the duration of a video loaded from sdcard, in my case the video.duration is giving a null value, any help would be appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants