-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added transcoding support for android and video trimming. #3
Conversation
Beautiful dude! Thanks again.. You're crushing it! |
Added transcoding support for android and video trimming.
@jbavari Thanks I'm going to start working on creating JPEG snapshots from video today. Appreciate all the help can't wait to get the next version of my app out that is already using this. |
Woohoo! |
This is great. I've worked with FFMPEG in linux quite a bit. Working on a For now, I think the encoding settings for the 3 quality levels should As a side note, it would nice to get FFMPEG going in the IOS version of the Encoding with FFMPEG, you could provide the following options from within Height, Width, Video Bitrate, Audio Bitrate, Audio Channels, Rotation, On Wed, Feb 4, 2015 at 12:41 PM, Ross Martin notifications@github.com
|
@oliverholmberg Awesome are you working on the Android version right now? I just added support for creating JPEG images from video in this new PR - #5 PR #5 fixes an issue with the wrong plugin class name for iOS. The plugin worked but the JS was calling the wrong plugin class but it is fixed now in the new PR. Looking forward to seeing where this goes, it's already changed the game for my Ionic app. Now my HTML5 videos run smooth on each platform and have posters!!! |
@rossmartin Copy that. I'm just changing a few ffmpeg settings based on the quality setting (for android versions), namely bitrate and framesize. I'll PR that in the next day or so. I don't really know where to begin with updating iOS to use ffmpeg. |
@oliverholmberg - it'd be nice to have FFMPEG on iphone, but realistically speaking, they probably wouldnt allow it due to 'invalid apis' being used. They already provide their own transcoding class. Here's to thinking big though! :) |
I'll bet you're right on that, however, there would have to be another way Cheers. On Thu, Feb 5, 2015 at 4:01 PM, Josh Bavari notifications@github.com
|
There are a few "ffmpeg for ios" projects out there. That is no guarantee https://github.com/chrisballinger/FFmpeg-iOS - This one has an obscure note On Thu, Feb 5, 2015 at 6:58 PM, Oliver Holmberg oliverholmberg@gigity.tv
|
Added transcoding support for android and video trimming.
This PR has a few additions and improvements:
duration
option.VideoEditorPlugin
toVideoEditor
.VideoEditorConstants
toVideoEditorOptions
.org.apache.cordova.videoediting
toorg.apache.cordova.videoeditor
.Next I will be adding the ability to grab JPEG snapshots from a video file and continuing to test/improve the plugin.