fix(static parser): Allow newlines in expressions.

Closes dart-archive#297
jbdeboer · Dec 5, 2013 · 59a50a0 · 59a50a0
1 parent 92a0b01
commit 59a50a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/bin/parser_generator_for_spec.dart b/bin/parser_generator_for_spec.dart
@@ -18,6 +18,7 @@ main(arguments) {
   // List generated using:
   // node node_modules/karma/bin/karma run | grep -Eo ":XNAY:.*:XNAY:" | sed -e 's/:XNAY://g' | sed -e "s/^/'/" | sed -e "s/$/',/" | sort | uniq > missing_expressions
   injector.get(isGetter ? ParserGetterSetter : ParserGenerator).generateParser([
+      "foo == 'bar' ||\nbaz"
       "null",
       "[1, 2].length",
       "doesNotExist",

diff --git a/lib/tools/parser_generator/source.dart b/lib/tools/parser_generator/source.dart
@@ -8,7 +8,10 @@ class SourceBuilder {
   Map<String, Code> refs = {};
   List<Code> codeRefs = [];
 
-  String str(String s) => '\'' + s.replaceAll('\'', '\\\'').replaceAll(r'$', r'\$') + '\'';
+  String str(String s) => '\'' +
+      s.replaceAll('\'', '\\\'')
+        .replaceAll('\n', '\\n')
+        .replaceAll(r'$', r'\$') + '\'';
   String ident(String s) => '_${s.replaceAll(NON_WORDS, '_')}_${s.hashCode}';
 
   String ref(Code code) {