fix(src,include,test): fixed multiple cases where a bad yaml was accepted #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pted. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
jbeder
requested changes
Sep 12, 2024
test/integration/load_node_test.cpp
Outdated
| EXPECT_THROW(Load(R"(,"foo")"), ParserException); | ||
| EXPECT_THROW(Load(R"(,foo)"), ParserException); | ||
|
|
||
| const char *doc_ok = R"( |
There was a problem hiding this comment.
Do you want to EXPECT_EQ what these actually parse to? (And maybe put them in the above "valid" test or their own one?
Plus, check that the content is what we actually expect. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
jbeder
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, i added test cases.
The yaml parser did not catch some strings related yaml issues, like:
This is linked to the discussion here: falcosecurity/falco#3281
Note: i am not an expert therefore please let me know if i can do anything better (or if the fix makes no sense at all :D )